fix: metadata tags capturing in v0 transformation #3492
Conversation
|
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3492/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3492 +/- ##
========================================
Coverage 88.06% 88.07%
========================================
Files 577 579 +2
Lines 31207 31238 +31
Branches 7442 7447 +5
========================================
+ Hits 27483 27513 +30
- Misses 3386 3387 +1
Partials 338 338 ☔ View full report in Codecov by Sentry. |
|
@Jayachand : Can you add brief description and a ticket for traceability purposes as well ? |
| ...(Object.keys(eventsMetadata).length ? getMetadata(Object.values(eventsMetadata)[0]) : {}), | ||
| ...(Object.keys(eventsMetadata).length | ||
| ? getTransformationMetadata(Object.values(eventsMetadata)[0]) | ||
| : {}), |
There was a problem hiding this comment.
Can you explain the issue here a bit ?
There was a problem hiding this comment.
v0 execute function receives only event messages. metadata is not attached to them. Earlier tag extraction getMetadata(events[0].metdata) always returns nil. So changed extraction to eventsMetadata
|
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
fixes DAT-1355
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.